Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] change default nrounds to 100 to match LightGBM core library default #4197

Merged
merged 3 commits into from
Apr 19, 2021
Merged

[R-package] change default nrounds to 100 to match LightGBM core library default #4197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
387de66
use same default arguments as python
david-cortes Apr 18, 2021
5c5f3ad
Update R-package/R/lgb.cv.R
david-cortes Apr 18, 2021
208acd3
revert change in docs
david-cortes Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R-package/R/lgb.cv.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ CVBooster <- R6::R6Class(
#' @export
lgb.cv <- function(params = list()
, data
, nrounds = 10L
, nfold = 3L
, nrounds = 100L
, nfold = 5L
david-cortes marked this conversation as resolved.
Show resolved Hide resolved
, label = NULL
, weight = NULL
, obj = NULL
Expand Down
2 changes: 1 addition & 1 deletion R-package/R/lgb.train.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
#' @export
lgb.train <- function(params = list(),
data,
nrounds = 10L,
nrounds = 100L,
valids = list(),
obj = NULL,
eval = NULL,
Expand Down
2 changes: 1 addition & 1 deletion R-package/R/lightgbm.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ lightgbm <- function(data,
label = NULL,
weight = NULL,
params = list(),
nrounds = 10L,
nrounds = 100L,
verbose = 1L,
eval_freq = 1L,
early_stopping_rounds = NULL,
Expand Down
4 changes: 2 additions & 2 deletions R-package/man/lgb.cv.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion R-package/man/lgb.train.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion R-package/man/lightgbm.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.