[docs] Add alt text on images (related to #4036) #4038

akshitadixit · 2021-03-02T07:11:22Z

This pull request mentions #4028 and modifies the following files only:

jameslamb · 2021-03-02T16:17:25Z

I apologize for the inconvenience, but could you please merge in the latest changes from master? We recently merged some fixes for failing continuous integration jobs (#4032)

akshitadixit · 2021-03-02T16:21:04Z

Sure

akshitadixit · 2021-03-09T15:28:19Z

@jameslamb if you could please let me know if the checks are failing on my end?

jameslamb · 2021-03-09T15:32:39Z

@jameslamb if you could please let me know if the checks are failing on my end?

I think it's very very unlikely that these checks are related to your changes. Sorry, we've been having a lot of problems with out continuous integration set up the last two weeks 😆

We have a few other pull requests in progress right now to fix the issues, and when those are merged I'll ask you to merge master into this PR.

Sorry I haven't come back for a review yet. I need to do a little research on how screen readers interpret separated-out acronyms like "G. B. M." compared to "GBM". If you know of any resources that describe that, I'd be grateful if you could share them with me.

akshitadixit · 2021-03-09T15:42:54Z

Definitely, thanks for informing.

Also I came across these articles and then chose full stops instead of simple spaces. Also tried it out with a tts to confirm.

jameslamb

Thanks so much for taking the time to do this, and for your patience with me as it took a long time for me to come back and give you a review.

Could you please consider the suggestions I just left? You can click "add to batch" in the browser and then "commit" after adding all of them to directly commit them, if you agree.

Can you also either merge in the latest master to this branch? Sorry for the inconvenience. We've had some issues recently with our automated continuous integration tests, and recent pull requests fixed those issues (I hope haha).

docs/GPU-Windows.rst

docs/GPU-Performance.rst

docs/GPU-Windows.rst

akshitadixit · 2021-03-20T03:49:46Z

Sure! Thanks for the suggestions, will do it.

Co-authored-by: James Lamb <[email protected]>

* [docs] Add alt text to image in Parameters-Tuning.rst (#4035) * [docs] Add alt text to image in Parameters-Tuning.rst Add alt text to Leaf-wise growth image, as part of #4028 * Update docs/Parameters-Tuning.rst Co-authored-by: James Lamb <[email protected]> Co-authored-by: James Lamb <[email protected]> * [ci] [R-package] upgrade to R 4.0.4 in CI (#4042) * [docs] update description of deterministic parameter (#4027) * update description of deterministic parameter to require using with force_row_wise or force_col_wise * Update include/LightGBM/config.h Co-authored-by: Nikita Titov <[email protected]> * update docs Co-authored-by: Nikita Titov <[email protected]> * [dask] Include support for init_score (#3950) * include support for init_score * use dataframe from init_score and test difference with and without init_score in local model * revert refactoring * initial docs. test between distributed models with and without init_score * remove ranker from tests * test value for root node and change docs * comma * re-include parametrize * fix incorrect merge * use single init_score and the booster_ attribute * use np.float64 instead of float * [ci] ignore untitle Jupyter notebooks in .gitignore (#4047) * [ci] prevent getting incompatible dask and distributed versions (#4054) * [ci] prevent getting incompatible dask and distributed versions * Update .ci/test.sh Co-authored-by: Nikita Titov <[email protected]> * empty commit Co-authored-by: Nikita Titov <[email protected]> * [ci] fix R CMD CHECK note about example timings (fixes #4049) (#4055) * [ci] fix R CMD CHECK note about example timings (fixes #4049) * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * empty commit Co-authored-by: Nikita Titov <[email protected]> * [ci] add CMake + R 3.6 test back (fixes #3469) (#4053) * [ci] add CMake + R 3.6 test back (fixes #3469) * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * Update .ci/test_r_package_windows.ps1 * -Wait and remove rtools40 * empty commit Co-authored-by: Nikita Titov <[email protected]> * [dask] include multiclass-classification task in tests (#4048) * include multiclass-classification task and task_to_model_factory dicts * define centers coordinates. flatten init_scores within each partition for multiclass-classification * include issue comment and fix linting error * Update index.rst (#4029) Add alt text to logo image Co-authored-by: James Lamb <[email protected]> * [dask] raise more informative error for duplicates in 'machines' (fixes #4057) (#4059) * [dask] raise more informative error for duplicates in 'machines' * uncomment * avoid test failure * Revert "avoid test failure" This reverts commit 9442bdf. * [dask] add tutorial documentation (fixes #3814, fixes #3838) (#4030) * [dask] add tutorial documentation (fixes #3814, fixes #3838) * add notes on saving the model * quick start examples * add examples * fix timeouts in examples * remove notebook * fill out prediction section * table of contents * add line back * linting * isort * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * move examples under python-guide * remove unused pickle import Co-authored-by: Nikita Titov <[email protected]> * set 'pending' commit status for R Solaris optional workflow (#4061) * [docs] add Yu Shi to repo maintainers (#4060) * Update FAQ.rst * Update CODEOWNERS * set is_linear_ to false when it is absent from the model file (fix #3778) (#4056) * Add CMake option to enable sanitizers and build gtest (#3555) * Add CMake option to enable sanitizer * Set up gtest * Address reviewer's feedback * Address reviewer's feedback * Update CMakeLists.txt Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: Nikita Titov <[email protected]> * added type hint (#4070) * [ci] run Dask examples on CI (#4064) * Update Parallel-Learning-Guide.rst * Update test.sh * fix path * address review comments * [python-package] add type hints on Booster.set_network() (#4068) * [python-package] add type hints on Booster.set_network() * change behavior * [python-package] Some mypy fixes (#3916) * Some mypy fixes * address James' comments * Re-introduce pass in empty classes * Update compat.py Remove extra lines * [dask] [ci] fix flaky network-setup test (#4071) * [tests][dask] simplify code in Dask tests (#4075) * simplify Dask tests code * enable CI * disable CI * Revert "[ci] prevent getting incompatible dask and distributed versions (#4054)" (#4076) This reverts commit 4e9c976. * Fix parsing of non-finite values (#3942) * Fix index out-of-range exception generated by BaggingHelper on small datasets. Prior to this change, the line "score_t threshold = tmp_gradients[top_k - 1];" would generate an exception, since tmp_gradients would be empty when the cnt input value to the function is zero. * Update goss.hpp * Update goss.hpp * Add API method LGBM_BoosterPredictForMats which runs prediction on a data set given as of array of pointers to rows (as opposed to existing method LGBM_BoosterPredictForMat which requires data given as contiguous array) * Fix incorrect upstream merge * Add link to LightGBM.NET * Fix indenting to 2 spaces * Dummy edit to trigger CI * Dummy edit to trigger CI * remove duplicate functions from merge * Fix parsing of non-finite values. Current implementation silently returns zero when input string is "inf", "-inf", or "nan" when compiled with VS2017, so instead just explicitly check for these values and fail if there is no match. No attempt to optimise string allocations in this implementation since it is usually rarely invoked. * Dummy commit to trigger CI * Also handle -nan in double parsing method * Update include/LightGBM/utils/common.h Remove trailing whitespace to pass linting tests Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: matthew-peacock <[email protected]> Co-authored-by: Guolin Ke <[email protected]> Co-authored-by: Nikita Titov <[email protected]> * [dask] remove unused imports from typing (#4079) * Range check for DCG position discount lookup (#4069) * Add check to prevent out of index lookup in the position discount table. Add debug logging to report number of queries found in the data. * Change debug logging location so that we can print the data file name as well. * Revert "Change debug logging location so that we can print the data file name as well." This reverts commit 3981b34. * Add data file name to debug logging. * Move log line to a place where it is output even when query IDs are read from a separate file. * Also add the out-of-range check to rank metrics. * Perform check after number of queries is initialized. * Update * [ci] upgrade R CI scripts to work on Ubuntu 20.04 (#4084) * [ci] install additional LaTeX packages in R CI jobs * update autoconf version * bump upper limit on package size to 100 * [SWIG] Add streaming data support + cpp tests (#3997) * [feature] Add ChunkedArray to SWIG * Add ChunkedArray * Add ChunkedArray_API_extensions.i * Add SWIG class wrappers * Address some review comments * Fix linting issues * Move test to tests/test_ChunkedArray_manually.cpp * Add test note * Move ChunkedArray to include/LightGBM/utils/ * Declare more explicit types of ChunkedArray in the SWIG API. * Port ChunkedArray tests to googletest * Please C++ linter * Address StrikerRUS' review comments * Update SWIG doc & disable ChunkedArray<int64_t> * Use CHECK_EQ instead of assert * Change include order (linting) * Rename ChunkedArray -> chunked_array files * Change header guards * Address last comments from StrikerRUS * store all CMake files in one place (#4087) * v3.2.0 release (#3872) * Update VERSION.txt * update appveyor.yml and configure * fix Appveyor builds Co-authored-by: James Lamb <[email protected]> Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: StrikerRUS <[email protected]> * [ci] Bump version for development (#4094) * Update .appveyor.yml * Update cran-comments.md * Update VERSION.txt * update configure Co-authored-by: James Lamb <[email protected]> * [ci] fix flaky Azure Pipelines jobs (#4095) * Update test.sh * Update setup.sh * Update .vsts-ci.yml * Update test.sh * Update setup.sh * Update .vsts-ci.yml * Update setup.sh * Update setup.sh Co-authored-by: Subham Agrawal <[email protected]> Co-authored-by: James Lamb <[email protected]> Co-authored-by: shiyu1994 <[email protected]> Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: jmoralez <[email protected]> Co-authored-by: marcelonieva7 <[email protected]> Co-authored-by: Philip Hyunsu Cho <[email protected]> Co-authored-by: Deddy Jobson <[email protected]> Co-authored-by: Alberto Ferreira <[email protected]> Co-authored-by: mjmckp <[email protected]> Co-authored-by: matthew-peacock <[email protected]> Co-authored-by: Guolin Ke <[email protected]> Co-authored-by: ashok-ponnuswami-msft <[email protected]> Co-authored-by: StrikerRUS <[email protected]>

jameslamb · 2021-03-23T15:56:45Z

@akshitadixit it looks like this branch has some conflicts with recent changes on master. I'd be happy to fix them if you'd like (they aren't related to your code). Can I push to your branch?

akshitadixit · 2021-03-23T16:04:03Z

@akshitadixit it looks like this branch has some conflicts with recent changes on master. I'd be happy to fix them if you'd like (they aren't related to your code). Can I push to your branch?

Sure, please do!

jameslamb

Thanks so much! These changes look great to me.

Are you interested in helping us to finish #4028? I'd be grateful for another pull request that adds alt text for any images in docs/Parallel-Learning-Guide.rst and docs/gcc-Tips.rst, if you have time and interest.

akshitadixit · 2021-03-23T17:04:45Z

Oh definitely! Will finish it off.

StrikerRUS

Very nice and detailed descriptions!
Please check some typos and add dots at the end for the consistency with descriptions in other files.

docs/Features.rst

docs/GPU-Performance.rst

docs/GPU-Windows.rst

Co-authored-by: Nikita Titov <[email protected]>

akshitadixit · 2021-03-24T03:21:14Z

Very nice and detailed descriptions!
Please check some typos and add dots at the end for the consistency with descriptions in other files.

Done the needful.

jameslamb · 2021-03-24T21:32:14Z

Looks good to me! @StrikerRUS I didn't want to overstep and dismiss your blocking review, so you'll have to approve before this can be merged.

StrikerRUS

@akshitadixit Thanks a lot for the contribution that required a thoughtful research and for quick fixes!

github-actions · 2023-08-23T23:57:35Z

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

[docs]Add alt text on images

11dc37f

akshitadixit requested review from huanzhang12, jameslamb, Laurae2 and StrikerRUS as code owners March 2, 2021 07:11

jameslamb added the doc label Mar 2, 2021

jameslamb changed the title ~~[docs]Add alt text on images (related to #4036)~~ [docs] Add alt text on images (related to #4036) Mar 2, 2021

jameslamb removed the request for review from huanzhang12 March 2, 2021 16:17

Merge https://github.com/microsoft/LightGBM

e730854

jameslamb self-assigned this Mar 12, 2021

jameslamb removed the request for review from Laurae2 March 12, 2021 22:13

jameslamb added the awaiting review label Mar 12, 2021

jameslamb requested changes Mar 19, 2021

View reviewed changes

akshitadixit and others added 5 commits March 23, 2021 13:12

Update docs/GPU-Windows.rst

03ff667

Co-authored-by: James Lamb <[email protected]>

Update docs/GPU-Windows.rst

0fc0f7b

Co-authored-by: James Lamb <[email protected]>

Apply suggestions from code review

721d7fa

Co-authored-by: James Lamb <[email protected]>

Apply suggestions from code review

8be88d0

Co-authored-by: James Lamb <[email protected]>

akshitadixit requested review from btrotta, chivee, guolinke, henry0312, shiyu1994 and wxchan as code owners March 23, 2021 08:08

merge master

3292878

jameslamb self-requested a review March 23, 2021 16:10

jameslamb approved these changes Mar 23, 2021

View reviewed changes

StrikerRUS requested changes Mar 23, 2021

View reviewed changes

Apply suggestions from code review

87e333f

Co-authored-by: Nikita Titov <[email protected]>

jameslamb removed the awaiting review label Mar 24, 2021

jameslamb requested a review from StrikerRUS March 24, 2021 21:27

StrikerRUS approved these changes Mar 25, 2021

View reviewed changes

StrikerRUS merged commit 6ad3e6e into microsoft:master Mar 25, 2021

github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Add alt text on images (related to #4036) #4038

[docs] Add alt text on images (related to #4036) #4038

akshitadixit commented Mar 2, 2021

jameslamb commented Mar 2, 2021

akshitadixit commented Mar 2, 2021

akshitadixit commented Mar 9, 2021

jameslamb commented Mar 9, 2021

akshitadixit commented Mar 9, 2021

jameslamb left a comment

akshitadixit commented Mar 20, 2021

jameslamb commented Mar 23, 2021

akshitadixit commented Mar 23, 2021

jameslamb left a comment

akshitadixit commented Mar 23, 2021

StrikerRUS left a comment

akshitadixit commented Mar 24, 2021

jameslamb commented Mar 24, 2021

StrikerRUS left a comment

github-actions bot commented Aug 23, 2023

[docs] Add alt text on images (related to #4036) #4038

[docs] Add alt text on images (related to #4036) #4038

Conversation

akshitadixit commented Mar 2, 2021

jameslamb commented Mar 2, 2021

akshitadixit commented Mar 2, 2021

akshitadixit commented Mar 9, 2021

jameslamb commented Mar 9, 2021

akshitadixit commented Mar 9, 2021

jameslamb left a comment

Choose a reason for hiding this comment

akshitadixit commented Mar 20, 2021

jameslamb commented Mar 23, 2021

akshitadixit commented Mar 23, 2021

jameslamb left a comment

Choose a reason for hiding this comment

akshitadixit commented Mar 23, 2021

StrikerRUS left a comment

Choose a reason for hiding this comment

akshitadixit commented Mar 24, 2021

jameslamb commented Mar 24, 2021

StrikerRUS left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2023