-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] prefer older binary to new source for R packages on Mac builds (fixes #4008) #4010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
ha we cannot win! Now the
Looks like some issue with version conflicts,coming from Line 223 in 646267d
Here are the last few lines
The full log is too large to copy into this comment, but you can view it at https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=9297&view=logs&j=c28dceab-947a-5848-c21f-eef3695e5f11. @StrikerRUS if you're available, could you re-run the failed jobs for this PR on Azure? Since you have permissions (#3819 (comment)) and I don't right now (#3819 (comment)). Sorry to bother you with it :/ |
Done! What CI job will fail next?.. |
that worked, thanks! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR proposes a fix to #4008. The root cause for that issues is that
{data.table}
recently did a release, but binaries are not available from CRAN yet for it. As a result, the newest version is being compiled from source in CI, and that compilation is failing.This PR proposes changing the strategy for installing dependencies to "install the newest binary" instead, so that such temporary situations won't disrupt CI and slow development on the entire project in the future.
This reverts the change made in #3876. Since R package builds have to pass for any LightGBM PRs to be merged, I think we should prefer minimizing disruptions even if it means that it takes an extra day or two for our CI to start using the newest version of a dependency.
How I tested this
I tested on my Mac. I could reproduce the original problem and confirm this fixes it.
source install
binary install
References
Based on the advice in https://community.rstudio.com/t/prefer-install-packages-from-binaries-in-windows/50760.