Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] Early stopping #3952

Closed
wants to merge 35 commits into from
Closed

[dask] Early stopping #3952

wants to merge 35 commits into from

Commits on Feb 9, 2021

  1. es WiP, need to add eval_sample_weight and eval_group

    @ffineis
    ffineis committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    08430cb View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. add weight, group to dask es. WiP.

    @ffineis
    ffineis committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    2b75814 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. dask es reorg

    @ffineis
    ffineis committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    77766e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Update python-package/lightgbm/dask.py 

    _train_part model.fit args to lines

Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    86341fc View commit details
    Browse the repository at this point in the history

  2. Update tests/python_package_test/test_dask.py 

    _train_part model.fit args to lines, pt2

Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    8d82646 View commit details
    Browse the repository at this point in the history

  3. Update python-package/lightgbm/dask.py 

    _train_part model.fit args to lines pt3

Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    69110b4 View commit details
    Browse the repository at this point in the history

  4. Update tests/python_package_test/test_dask.py 

    dask_model.fit args to lines

Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    69b45dd View commit details
    Browse the repository at this point in the history

  5. Update tests/python_package_test/test_dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    ee5f157 View commit details
    Browse the repository at this point in the history

  6. Update python-package/lightgbm/dask.py 

    use is instead of id()

Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c96be2f View commit details
    Browse the repository at this point in the history

  7. Update python-package/lightgbm/dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    04040fc View commit details
    Browse the repository at this point in the history

  8. Update python-package/lightgbm/dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    cf720c9 View commit details
    Browse the repository at this point in the history

  9. Update python-package/lightgbm/dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c0d8ae6 View commit details
    Browse the repository at this point in the history

  10. Update tests/python_package_test/test_dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    5d19b50 View commit details
    Browse the repository at this point in the history

  11. Update tests/python_package_test/test_dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    4421736 View commit details
    Browse the repository at this point in the history

  12. Update python-package/lightgbm/dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    65f98e5 View commit details
    Browse the repository at this point in the history

  13. Update python-package/lightgbm/dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    6d14586 View commit details
    Browse the repository at this point in the history

  14. Update python-package/lightgbm/dask.py 

    Co-authored-by: James Lamb <[email protected]>
    @ffineis @jameslamb
    ffineis and jameslamb authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    6737acd View commit details
    Browse the repository at this point in the history

  15. applying changes to eval_set PR WiP

    @ffineis
    ffineis committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    7099204 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. dask support for eval_names, eval_metric, eval_stopping_rounds

    @ffineis
    ffineis committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    18cd42c View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. add evals_result checks and other eval_set attribute-related test che… 

    …cks. need to merge master - WiP
    @ffineis
    ffineis committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1335591 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. resolve conflix

    @ffineis
    ffineis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    c67cae5 View commit details
    Browse the repository at this point in the history

  2. fix lint errors in test_dask.py

    @ffineis
    ffineis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    609d8a0 View commit details
    Browse the repository at this point in the history

  3. drop group_shape from _lgbmmodel_doc_fit.format for non-rankers, add … 

    …support for eval_at for dask ranker
    @ffineis
    ffineis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    0102bc7 View commit details
    Browse the repository at this point in the history

  4. add eval_at to test_dask eval_set ranker tests

    @ffineis
    ffineis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    b03715a View commit details
    Browse the repository at this point in the history

  5. add back group_shape to lgbmmmodel docs, tighten tests

    @ffineis
    ffineis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    dfb3c72 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. drop random eval weights from early stopping, probably causing traini… 

    …ng to terminate too early
    @ffineis
    ffineis committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    82cf159 View commit details
    Browse the repository at this point in the history

  2. add eval data templates to sklearn fit docs, add eval data docs to dask

    @ffineis
    ffineis committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    8341074 View commit details
    Browse the repository at this point in the history

  3. add n_features to _create_data, eval_set tests stop w/ desirable tree… 

    … counts
    @ffineis
    ffineis committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    d232b0b View commit details
    Browse the repository at this point in the history

  4. import alphabetically

    @ffineis
    ffineis committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    e56251d View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. resolve merge conflix

    @ffineis
    ffineis committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    10f6e58 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. fix conflix from 3994

    @ffineis
    ffineis committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    96fe750 View commit details
    Browse the repository at this point in the history

  2. add back get_worker for eval_set error handling

    @ffineis
    ffineis committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b9cc723 View commit details
    Browse the repository at this point in the history

  3. test_dask argmin typo

    @ffineis
    ffineis committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    f593fd5 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. push forgotten eval_names bugfix

    @ffineis
    ffineis committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    1548559 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. eval_stopping_rounds -> early_stopping_rounds, fix failing non-es test

    @ffineis
    ffineis committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    22f1ba4 View commit details
    Browse the repository at this point in the history