-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Reorganize documentation on distributed learning (fixes #3596) #3951
Conversation
Build Parallel Version | ||
---------------------- | ||
Integrations | ||
------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -78,11 +111,13 @@ Then write these IP in one file (assume ``mlist.txt``) like following: | |||
|
|||
**Note**: For Windows users, need to start "smpd" to start MPI service. More details can be found `here`_. | |||
|
|||
Run Parallel Learning | |||
--------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,5 +1,6 @@ | |||
Parallel Learning Example | |||
========================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,24 +1,19 @@ | |||
Parallel Learning Guide | |||
======================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think this is ready for review! Docs builds are passing (https://readthedocs.org/projects/lightgbm/builds/). You can explore this PR's docs at https://lightgbm.readthedocs.io/en/docs-jlamb/. I believe I've accounted for all old links by adding custom anchors. I left comments on each line of the diff that removes a heading, showing a link using the old anchor. If you notice any others that are missed, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb Nice work! Just few comments below.
Co-authored-by: Nikita Titov <[email protected]>
Co-authored-by: Nikita Titov <[email protected]>
closing and re-opening to retrigger CI, thanks to this infrastructure issue on Azure:
Closing and reopening instead of pushing an empty commit because I'm on mobile right now, and there is currently only one other build in progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR finishes #3596 (that work was started in #4000), changing the terminology "parallel learning" or "parallel training" to "distributed learning" and "distributed training".
This also re-organizes the the guide on distributed learning. In this proposed reorganization, the guide would have two top-level sections.
In future PRs (for #3814, for example), I'll propose expanding the "integrations --> Dask" section substantially, with code samples and discussion of Dask-specific topics, like how to choose a good partition size and number of partitions, or how to use the Dask package in an environment constrained by firewall rules (#3994 (comment)).