Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] Add support for 'pred_leaf' in Dask estimators (fixes #3792) #3919

Merged
merged 8 commits into from
Feb 7, 2021

Conversation

jameslamb
Copy link
Collaborator

This PR adds support in the Dask module for getting indices of the leaf nodes in each tree that each observation in a dataset falls into, via .predict(X, pred_leaf=True). It fixes #3792.

This brings the Dask module a step closer to feature parity with the estimators available from lightgbm.sklearn.

Notes for Reviewers

These tests also led to the discovery of this bug: #3918

tests/python_package_test/test_dask.py Outdated Show resolved Hide resolved
tests/python_package_test/test_dask.py Outdated Show resolved Hide resolved
tests/python_package_test/test_dask.py Outdated Show resolved Hide resolved
tests/python_package_test/test_dask.py Outdated Show resolved Hide resolved
tests/python_package_test/test_dask.py Outdated Show resolved Hide resolved
tests/python_package_test/test_dask.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@jameslamb jameslamb merged commit 37485ff into microsoft:master Feb 7, 2021
@jameslamb jameslamb deleted the feat/pred-leaf branch February 7, 2021 19:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dask] support 'pred_leaf' in predict()
2 participants