Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask][tests] skip Dask tests when Dask is not installed and improve imports in Dask tests #3852

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Use benefits of #3822 and import DaskLGBM* classes from the root.

Import only things that are really used.

Skip test_dask.py when Dask is not installed. This is necessary to not force non-Dask contributors install all Dask stuff to run tests locally.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jameslamb jameslamb merged commit f21e0ef into master Jan 25, 2021
@jameslamb jameslamb deleted the dask_test branch January 25, 2021 14:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants