Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] Drop aliases of core network parameters #3843

Merged
merged 3 commits into from
Jan 24, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

Most network params in Dask module is constructed manually based on IPs and ports.
We need to drop all aliases from params to not confuse LightGBM cpp code with multiple values for the same param.

machine_list = ','.join([
'%s:%d' % (urlparse(worker_address).hostname, port)
for worker_address, port
in worker_address_to_port.items()
])
network_params = {
'machines': machine_list,
'local_listen_port': worker_address_to_port[local_worker_address],
'time_out': time_out,
'num_machines': len(worker_address_to_port)
}

@StrikerRUS StrikerRUS merged commit 98a85a8 into master Jan 24, 2021
@StrikerRUS StrikerRUS deleted the dask_aliases branch January 24, 2021 20:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants