Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask][tests] move make_ranking into utils #3827

Merged
merged 2 commits into from
Jan 24, 2021
Merged

[dask][tests] move make_ranking into utils #3827

merged 2 commits into from
Jan 24, 2021

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Jan 23, 2021

This can speed up tests by caching and also makes make_ranking function available for non-Dask tests.

UPD: OK, we cannot cache it due to unhashable group argument.

Diff for make_ranking (docstring fixed):

https://www.textcompare.org/index.html?id=600cacc151271d00170ec70c

image

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh awesome! good idea. Thanks again for contributing this @ffineis

@jameslamb jameslamb merged commit da44387 into master Jan 24, 2021
@jameslamb jameslamb deleted the dask_test branch January 24, 2021 00:15
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants