Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] fix Dask import order #3788

Merged
merged 2 commits into from
Jan 19, 2021
Merged

[dask] fix Dask import order #3788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8865e1f
[dask] fix Dask import order
jameslamb Jan 19, 2021
caf98f6
Merge branch 'master' into misc/dask-order
jameslamb Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python-package/lightgbm/dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

import numpy as np
import pandas as pd
import scipy.sparse as ss

from dask import array as da
from dask import dataframe as dd
from dask import delayed
Expand All @@ -20,8 +22,6 @@
from .basic import _LIB, _safe_call
from .sklearn import LGBMClassifier, LGBMRegressor

import scipy.sparse as ss

logger = logging.getLogger(__name__)


Expand Down
4 changes: 2 additions & 2 deletions tests/python_package_test/test_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test_training_does_not_fail_on_port_conflicts(client):
n_estimators=5,
num_leaves=5
)
for i in range(5):
for _ in range(5):
dask_classifier.fit(
X=dX,
y=dy,
Expand Down Expand Up @@ -204,7 +204,7 @@ def test_regressor_quantile(output, client, listen_port, alpha):


def test_regressor_local_predict(client, listen_port):
X, y, w, dX, dy, dw = _create_data('regression', output='array')
X, y, _, dX, dy, dw = _create_data('regression', output='array')

dask_regressor = dlgbm.DaskLGBMRegressor(
local_listen_port=listen_port,
Expand Down