Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a refactoring of
tests/python_package_test/test_dask.py
, to reduce the runtime of the Dask tests.n_estimators=10
andnum_leaves=10
(the defaults aren_estimators=100
andnum_leaves=31
)predict_proba()
tests forDaskLGBMClassifier
into the existingtest_classifier
test. I don't think effectively testingpredict()
andpredict_proba()
requires separate training runsImpact of this change
I tried running
pytest tests/python_package_test/test_dask.py
5 times onmaster
and 5 times on this branch (on my laptop). I found that the changes in this PR reduce the runtime of the Dask tests by around 35 seconds.I think this speedup will have a meaningful impact on development speed for the Dask module.
Notes for Reviewers
n_estimators
in thetest_regression
test. That test requires a lot of iterations from distributed and local training to look similar, and I found that they produced very different results for small values ofn_estimators
.