[ci] Move check-docs and lint jobs off Travis #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
reviewed
Jan 4, 2021
Co-authored-by: Nikita Titov <[email protected]>
… ci/lint-and-docs
|
ok I think this is ready for another review |
StrikerRUS
reviewed
Jan 6, 2021
StrikerRUS
reviewed
Jan 6, 2021
Co-authored-by: Nikita Titov <[email protected]>
… ci/lint-and-docs
jameslamb
commented
Jan 7, 2021
StrikerRUS
approved these changes
Jan 7, 2021
Comment on lines
39
to
40
| export OS_NAME="linux" | ||
| export COMPILER="gcc" |
There was a problem hiding this comment.
I think we can move these variables to env section of this config file closer to PYTHON_VERSION and other constants.
Co-authored-by: Nikita Titov <[email protected]>
jameslamb
added a commit
that referenced
this pull request
Jan 7, 2021
jameslamb
added a commit
that referenced
this pull request
Jan 13, 2021
* [ci] move CI jobs from Travis to Azure DevOps (fixes #3519) * comment out other CIs to avoid wasting cycles * try without docker * add container back * stop using --user in pip install * run check-docs and lint without container * job names * move more jobs to Azure-hosted Linux pool * fix PATH for check-docs * uncomment other CI * uncomment windows * remove uses of maxParallel * try moving macos-latest jobs to GitHub Actions * fix config * fix missing conda env * set Python version * remove commented-out code * add more to GitHub Actions * try to fix GPU * remove static_analysis to prevent conflicts with #3726 * change workflow name * try using ubuntu:latest docker * fix conda * trying to find where permissions first break * add workaround for sudo * please azure please * image syntax * more sudo * noninteractive * LC_ALL * more sudo * more stuff * CONDA dir * paths * get path * missing CONDA * fix path stuff * more tests * fix graphviz * stuff * more graphviz * install xorg-libxau * graphviz works, run more jobs * stuff * enable more tests * uncomment GitHub Actions * uncomment all other CIs * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * add travis.yml to Rbuildignore * add Rbuildignore rule for fmt * add libomp for clang builds * changes from code review Co-authored-by: Nikita Titov <[email protected]>
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #3519 , we're in the process of removing all CI jobs that run on Travis and moving them to GitHub Actions.
This PR moves
check-docsandlintto GitHub Actions. I wanted to do this one by itself to make #3672 smaller. These two jobs are also the easiest to move.This PR proposes putting
check-docsandlintinto a separate GitHub Actions workflow called "Static Analysis". Today, GitHub Actions does not allow you to re-run individual failed jobs. So if one job fails for random or temporary reasons, you have to re-run all jobs in the workflow. Since thecheck-docstasks fails somewhat regularly due to temporary network problems, I think it is a good idea to keep it +lintseparate, so that the cost of re-running it is low.Thanks for reviewing all of these @StrikerRUS . I know it's a lot of PRs but hopefully the end result will be that our CI is more stable.