Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove maxParallel limits on Azure DevOps #3725

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

jameslamb
Copy link
Collaborator

Trying to take the non-controversial changes off of #3672 to make that PR smaller, and to get some changes onto master without needing to wait on that PR.

This PR is based on #3672 (comment)

Could you please remove all occurrences of the maxParallel param to give Azure full control under the jobs' queue?

Per https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema#job, maxParallel in an Azure DevOps pipeline config controls the maximum number of jobs to try to run simultaneously. This limit might be useful if you have some autoscaling set up or if you had some reason to want to slow down, but for our purposes it would be better to just let the default limits work and try to max out the utilization of the Microsoft-hosted runners.

This change shouldn't change anything about our current CI, since we already set maxParallel exactly equal to the number of matrix jobs. But it means that in the future when we add / remove Azure jobs, this will be one less thing that has to be changed.

@jameslamb jameslamb merged commit fc1b930 into microsoft:master Jan 4, 2021
@jameslamb jameslamb deleted the ci/remove-azure-limits branch January 4, 2021 20:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants