Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove unused CI checks, other small simplifications #3688

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Conversation

jameslamb
Copy link
Collaborator

This PR proposes a few of the small changes from #3672, which I think should be non-controversial. Hopefully this will make that PR's diff smaller and make it easier to review.

  • removes [[ $TRAVIS == "true" ]] checks on check-docs and lint tasks
    • the fact that we happen to currently run those tasks on Travis doesn't need to be guarded in the code
  • sets AZURE=true as a global variable in Azure DevOps config, reducing duplication
  • changes the condition if [[ $TRAVIS == "true" ]] || [[ $GITHUB_ACTIONS == "true" ]] to simply if [[ $SETUP_CONDA != "false" ]];
    • this condition was capturing "Linux jobs on Azure run in a container that already has conda, and all other jobs need to set it up". I think it's more explicit and less error-prone to just have setup.sh install conda by default, and allow turning that off with a variable SETUP_CONDA

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jameslamb jameslamb merged commit be1202d into master Dec 28, 2020
@jameslamb jameslamb deleted the ci/cleanup branch December 28, 2020 15:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants