Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] remove unused R_AS_INT64 #3686

Merged
merged 2 commits into from
Jan 3, 2021
Merged

[R-package] remove unused R_AS_INT64 #3686

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33ed9ca
[R-package] remove unused R_AS_INT64
jameslamb Dec 27, 2020
d9a48ff
Merge branch 'master' into fix/remove-r-unused
jameslamb Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions R-package/src/R_object_helper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ typedef union { VECTOR_SER s; double align; } SEXPREC_ALIGN;

#define R_AS_INT(x) (*(reinterpret_cast<int*> DATAPTR(x)))

#define R_AS_INT64(x) (*(reinterpret_cast<int64_t*> DATAPTR(x)))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gha run r-valgrind

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/microsoft/LightGBM/runs/1613261778?check_suite_focus=true

#define R_IS_NULL(x) ((*reinterpret_cast<LGBM_SE>(x)).sxpinfo.type == 0)

// 64bit pointer
Expand Down