Added static cast from double to float #3678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3677
Compile warnings have been fixed,
double
andfloat
types where having issues whendouble
values were assigned to afloat
type vector. In this case, the solution was just using astatic_cast<float>(doubleVal)
construction, which would lower thedouble
value precission in order to fill the targetfloat
space.There is to say that there could be a data loss during this process (not anything different than before), so it should be studied if
double
is the desired type for thefeatures_values
vector or it should befloat
type.It would be desirable to use
.at()
instead of[]
in order to throw exceptions when incorrect array positions are consulted.