-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] upgrade GitHub Actions third-party actions to newest versions #3524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this line as well.
LightGBM/.github/workflows/cuda.yml
Line 41 in 12e220b
uses: actions/checkout@v1 |
ah missed that one! |
@@ -13,7 +13,7 @@ jobs: | |||
container: wch1/r-debug | |||
steps: | |||
- name: Checkout repository | |||
uses: actions/checkout@v1 | |||
uses: actions/checkout@v2.3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/gha run r-valgrind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like valgrind is happy with this change. I did check before that the image we use for valgrind tests had a recent version of git
in it, and it does.
https://github.com/microsoft/LightGBM/runs/1349685476?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one minor comment below.
Co-authored-by: Nikita Titov <[email protected]>
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
I've been noticing a bunch of these warnings in GitHub Actions jobs:
For example, you can see these annotations on https://github.com/microsoft/LightGBM/actions/runs/343069981.
To be sure that these changes from GitHub don't disrupt our CI, this PR updates the GitHub Actions workflows in this project to use the newest versions of third-party actions. You can see, specifically, that updates to deal with this deprecation were made in the most recent release of
actions/checkout
: https://github.com/actions/checkout/releases/tag/v2.3.4It also fixes a mistake I made setting them up....we should be using https://github.com/conda-incubator/setup-miniconda, not this fork of it: https://github.com/goanpeca/setup-miniconda.