Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upgrade GitHub Actions third-party actions to newest versions #3524

Merged
merged 6 commits into from
Nov 6, 2020

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Nov 3, 2020

I've been noticing a bunch of these warnings in GitHub Actions jobs:

The add-path command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

The set-env command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

For example, you can see these annotations on https://github.com/microsoft/LightGBM/actions/runs/343069981.

To be sure that these changes from GitHub don't disrupt our CI, this PR updates the GitHub Actions workflows in this project to use the newest versions of third-party actions. You can see, specifically, that updates to deal with this deprecation were made in the most recent release of actions/checkout: https://github.com/actions/checkout/releases/tag/v2.3.4

It also fixes a mistake I made setting them up....we should be using https://github.com/conda-incubator/setup-miniconda, not this fork of it: https://github.com/goanpeca/setup-miniconda.

@jameslamb jameslamb requested a review from StrikerRUS November 3, 2020 18:20
@jameslamb jameslamb requested a review from Laurae2 as a code owner November 3, 2020 18:20
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this line as well.

uses: actions/checkout@v1

@jameslamb
Copy link
Collaborator Author

Please update this line as well.

uses: actions/checkout@v1

ah missed that one!

@@ -13,7 +13,7 @@ jobs:
container: wch1/r-debug
steps:
- name: Checkout repository
uses: actions/checkout@v1
uses: actions/checkout@v2.3.4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gha run r-valgrind

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like valgrind is happy with this change. I did check before that the image we use for valgrind tests had a recent version of git in it, and it does.

https://github.com/microsoft/LightGBM/runs/1349685476?check_suite_focus=true

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor comment below.

.github/workflows/r_package.yml Outdated Show resolved Hide resolved
@StrikerRUS StrikerRUS merged commit 5dbd1df into microsoft:master Nov 6, 2020
@jameslamb jameslamb deleted the ci/fix-actions branch November 6, 2020 03:43
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants