[R-package] fix MM_PREFETCH and MM_MALLOC checks in configure.ac #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Oct 31, 2020
| @@ -402,6 +402,7 @@ python-package/lightgbm/VERSION.txt | |||
|
|
|||
| # R build artefacts | |||
| **/autom4te.cache/ | |||
| conftest* | |||
There was a problem hiding this comment.
/gha run r-valgrind
There was a problem hiding this comment.
valgrind is happy!
https://github.com/microsoft/LightGBM/actions/runs/338827520
StrikerRUS
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
@jameslamb Happy to see this bugfix! Awesome job, thanks a lot! I remember I was very upset seeing this check failing for CRAN.
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in the CRAN package
MM_PREFETCHandMM_MALLOCchecksint main(...)scaffolding inMM_PREFETCHandMM_MALLOCchecks, which was causing them to failMore explanation
Look at the diff for
R-package/configureand the autoconf documentation on AC_LANG_CONFTEST...autoconf adds that scaffolding for you! So this check wasalways failing for the CRAN package on Mac and Linuxfailing for the CRAN on Mac, because the conftest code has an extraint main(...)!!NOTE: Once CI runs, I'm going to update this and a table here comparing theMM_MALLOCandMM_PREFETCHcheck results for CRAN vs. CMake builds...I think they'll match now.Comparison of R 4.0 builds
✅ below means
❌ means
Latest commit on
master: https://github.com/microsoft/LightGBM/actions/runs/338789296MM_PREFETCH ❌
MM_PREFETCH ✅
MM_PREFETCH ✅
MM_PREFETCH ✅
MM_PREFETCH ✅
MM_PREFETCH ✅
this PR: https://github.com/microsoft/LightGBM/actions/runs/338808198
MM_PREFETCH ✅
MM_PREFETCH ✅
MM_PREFETCH ✅
MM_PREFETCH ✅
MM_PREFETCH ✅
MM_PREFETCH ✅
Notes for Reviewers
@StrikerRUS I am really glad you asked me about the compiler used in
R-package/configure.acin #3509 (review). I think I misunderstood your question the first time I read it, but that misunderstanding led me to an investigation that resulted in fixing a bug 😀@guolinke I think we should try to get this into 3.1.0 (#3484)