-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Updated lgb.train.R with keyword arguments #3452
Conversation
Hi @jameslamb. Can you please regenerate the docs and guide me how can I run the checks again. Thanks:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! I've requested a few changes to this PR. In addition, can you please also add the appropriate keyword arguments for the following calls?
- (line 250)
categorize.callbacks()
- (line 255)
booster$set_train_data_name()
- (line 259)
booster$add_valid()
thanks so much for the pull request! I've left some requested changes. Once those have been made, I can come update the documentation. |
Hi @jameslamb I have fixed the changes which you have suggested. Most of the checks have passed but in 3 of the checks I am getting following error:
Is that a problem or is it ready for merge? |
this happens sometimes and is definitely unrelated to your changes. I just restarted the builds, hopefully they'll pass. |
Thanks @jameslamb for running the checks again. I hope it will pass all the check this time. |
It looks like we have an ongoing issue with the MikTeX ecosystem (#3454 ). I'll merge this PR once I'm able to fix that, apologies. |
Thanks @jameslamb :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok now the tests are passing!
Thanks very much for contributing, @iadi7ya . I hope you'll consider contributing more in the future 😀
That's awesome @jameslamb ! I'd love to keep contributing to this wonderful project :) |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixes lgb.train.R from a list of functions listed on #3390