Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/optimize single prediction #2992

Merged
merged 15 commits into from
Jul 15, 2020
Merged

Feat/optimize single prediction #2992

merged 15 commits into from
Jul 15, 2020

Commits on Jul 11, 2020

  1. [performance] Add Fast methods to C API for SingleRow Predictions 

     * Add methods to C API to make single-row predictions faster:

   - LGBM_BoosterPredictForMatSingleRowFastInit (setup)
   - LGBM_BoosterPredictForMatSingleRowFast (predict)
   - LGBM_FastConfigFree (cleanup setup outputs)
    @AlbertoEAF
    alberto.ferreira authored and AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    9895b39 View commit details
    Browse the repository at this point in the history

  2. Code syle cleanup

    @AlbertoEAF
    Alberto Ferreira authored and AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    524233d View commit details
    Browse the repository at this point in the history

  3. Fix lint errors

    @AlbertoEAF
    Alberto Ferreira authored and AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    c9288c7 View commit details
    Browse the repository at this point in the history

  4. [performance] Revert FastConfig improvement to pass data at init 

    This reduces optimization by 5% / 30% with this branch but makes it so it can be used for higher level wrappers in MMLSpark.
And outside it as well.
    @AlbertoEAF
    AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    05e2269 View commit details
    Browse the repository at this point in the history

  5. [performance] Introduce Fast variants for SingleRow predictors. 

    Although this already provides performance gains by itself for any
callers, two new functions were added to Java's SWIG interfaces to
exploit that AND the GetPrimitiveArrayCritical data fetches.
    @AlbertoEAF
    AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    a507d3e View commit details
    Browse the repository at this point in the history

  6. [tests/profiling] Profile Fast predict methods 

    Build with -DBUILD_PROFILING_TESTS=ON and copy the default
model trained on the Higgs dataset from the benchmarks repo

 https://github.com/guolinke/boosting_tree_benchmarks.git

to LightGBM repo root and run the lightgbm_profile_* binaries.

The single instance used is the first row from that dataset.
    @AlbertoEAF
    Alberto Ferreira authored and AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    41d3465 View commit details
    Browse the repository at this point in the history

  7. Update comment on CMakeLists.

    @AlbertoEAF
    AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    1da1ae3 View commit details
    Browse the repository at this point in the history

  8. Fix doxygen-introduced issue (#threads)

    @AlbertoEAF
    AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    462f8c3 View commit details
    Browse the repository at this point in the history

  9. Fix conflicts due to new RowFunctionFromCSR signature in master

    @AlbertoEAF
    AlbertoEAF committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    c8d9724 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2020

  1. Change FastConfig ncol to int32_t.

    @AlbertoEAF
    AlbertoEAF committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    4813251 View commit details
    Browse the repository at this point in the history

  2. Removed profiling folder

    @AlbertoEAF
    AlbertoEAF committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    e36381e View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. fix doxygen typo include/LightGBM/c_api.h 

    Co-authored-by: Nikita Titov <[email protected]>
    @AlbertoEAF @StrikerRUS
    AlbertoEAF and StrikerRUS authored Jul 14, 2020
    Configuration menu
    Copy the full SHA
    1062588 View commit details
    Browse the repository at this point in the history

  2. fix doxygen typo include/LightGBM/c_api.h 

    Co-authored-by: Nikita Titov <[email protected]>
    @AlbertoEAF @StrikerRUS
    AlbertoEAF and StrikerRUS authored Jul 14, 2020
    Configuration menu
    Copy the full SHA
    3dd7a8e View commit details
    Browse the repository at this point in the history

  3. fix doxygen typo include/LightGBM/c_api.h 

    Co-authored-by: Nikita Titov <[email protected]>
    @AlbertoEAF @StrikerRUS
    AlbertoEAF and StrikerRUS authored Jul 14, 2020
    Configuration menu
    Copy the full SHA
    08a7f92 View commit details
    Browse the repository at this point in the history

  4. Doxygen: change new docstrings to double back-quote

    @AlbertoEAF
    AlbertoEAF committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    d8c37c0 View commit details
    Browse the repository at this point in the history