Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't save num_thread as possible #2839

Merged
merged 8 commits into from
Mar 2, 2020
Merged

don't save num_thread as possible #2839

merged 8 commits into from
Mar 2, 2020

Conversation

guolinke
Copy link
Collaborator

No description provided.

@guolinke guolinke requested a review from chivee as a code owner February 28, 2020 09:50
guolinke
guolinke commented Feb 28, 2020
View reviewed changes
docs/Parameters.rst Outdated Show resolved Hide resolved
guolinke
guolinke commented Feb 28, 2020
View reviewed changes
include/LightGBM/config.h Outdated Show resolved Hide resolved
StrikerRUS
StrikerRUS reviewed Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a story behind this?

include/LightGBM/config.h Outdated Show resolved Hide resolved
guolinke
guolinke commented Feb 29, 2020
View reviewed changes
docs/Parameters.rst Outdated Show resolved Hide resolved
@StrikerRUS
Copy link
Collaborator

Do you have a story behind this?

Never mind, found it: #2820.

StrikerRUS
StrikerRUS approved these changes Feb 29, 2020
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same name across the project makes it easier to perform a search.

src/metric/map_metric.hpp Outdated Show resolved Hide resolved
src/metric/map_metric.hpp Outdated Show resolved Hide resolved
src/metric/map_metric.hpp Outdated Show resolved Hide resolved
@guolinke guolinke added the fix label Mar 1, 2020
@guolinke guolinke merged commit 0aa7bfe into master Mar 2, 2020
@guolinke guolinke deleted the num_threads branch March 2, 2020 05:16
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@chivee chivee Awaiting requested review from chivee

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner

@Laurae2 Laurae2 Awaiting requested review from Laurae2

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guolinke @StrikerRUS