Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change locking strategy of Booster, allow for share and unique locks #2760

Merged
merged 55 commits into from
Jul 19, 2020
Merged

feat: Change locking strategy of Booster, allow for share and unique locks #2760

merged 55 commits into from
Jul 19, 2020

Commits on Feb 3, 2020

  1. Add capability to get possible max and min values for a model

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    971720f View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. Change implementation to have return value in tree.cpp, change naming… 

    … to upper and lower bound, move implementation to gdbt.cpp
    @JoanFM
    JoanFM authored and joanfontanals committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    3c49f4c View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Update include/LightGBM/c_api.h 

    Co-Authored-By: Nikita Titov <[email protected]>
    @JoanFM @StrikerRUS
    JoanFM and StrikerRUS authored Feb 5, 2020
    Configuration menu
    Copy the full SHA
    48a9474 View commit details
    Browse the repository at this point in the history

  2. Change iteration to avoid potential overflow, add bindings to R and P… 

    …ython and a basic test
    @JoanFM
    JoanFM committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    0d516c1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/microsoft/LightGBM into m… 

    …ax_min_leafs
    joanfontanals committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    f14ca1f View commit details
    Browse the repository at this point in the history

  4. Adjust test values

    joanfontanals committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    8c58493 View commit details
    Browse the repository at this point in the history

  5. Consider const correctness and multithreading protection

    @JoanFM
    JoanFM committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    019bda8 View commit details
    Browse the repository at this point in the history

  6. Put everything possible as const

    @JoanFM
    JoanFM committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    a794241 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Include shared_mutex, for now as unique_lock

    @JoanFM
    JoanFM committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    70ca8fc View commit details
    Browse the repository at this point in the history

  2. Update test values

    joanfontanals committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    c43bf1c View commit details
    Browse the repository at this point in the history

  3. Put everything possible as const

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    87ee70f View commit details
    Browse the repository at this point in the history

  4. Include shared_mutex, for now as unique_lock

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    fd24844 View commit details
    Browse the repository at this point in the history

  5. Make PredictSingleRow const and share the lock with other reading thr… 

    …eads
    joanfontanals committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    65cde98 View commit details
    Browse the repository at this point in the history

  6. Update test values

    @JoanFM
    joanfontanals authored and JoanFM committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    cfa612b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. Add test to check that model is exactly the same in all platforms

    @JoanFM
    JoanFM committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    d3a54ae View commit details
    Browse the repository at this point in the history

  2. Try to parse the model to get the expected values

    @JoanFM
    JoanFM committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    8ae8f3e View commit details
    Browse the repository at this point in the history

  3. Try to parse the model to get the expected values

    @JoanFM
    JoanFM committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    3713151 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'max_min_leafs' of https://github.com/JoanFM/LightGBM in… 

    …to max_min_leafs
    @JoanFM
    JoanFM committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    1cd8a9d View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. Fix implementation, num_leaves can be lower than the leaf_value_ size

    @JoanFM
    JoanFM committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    c7185a0 View commit details
    Browse the repository at this point in the history

  2. Do not check for num_leaves to be smaller than actual size and get ba… 

    …ck to test with hardcoded value
    @JoanFM
    JoanFM committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    fd0bdb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Merge branch 'max_min_leafs' of https://github.com/JoanFM/LightGBM in… 

    …to max_min_leafs
    @JoanFM
    JoanFM authored and joanfontanals committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    d6ca4ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/microsoft/LightGBM into m… 

    …ax_min_leafs
    @JoanFM
    JoanFM authored and joanfontanals committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    a753edf View commit details
    Browse the repository at this point in the history

  3. Change test order

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    19234e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Add gpu_use_dp option in test

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    00bdde1 View commit details
    Browse the repository at this point in the history

  2. Remove helper test method

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    82c677c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'read_write_locks' of https://github.com/JoanFM/LightGBM … 

    …into read_write_locks
    @JoanFM
    JoanFM committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    46092fd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'max_min_leafs' of https://github.com/JoanFM/LightGBM in… 

    …to read_write_locks
    @JoanFM
    JoanFM committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    397667c View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Remove TODO

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    46c4658 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Add preprocessing option to compile with c++17

    @JoanFM
    JoanFM authored and joanfontanals committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    9d1a31a View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Update python-package/setup.py 

    Co-Authored-By: Nikita Titov <[email protected]>
    @JoanFM @StrikerRUS
    JoanFM and StrikerRUS authored Feb 19, 2020
    Configuration menu
    Copy the full SHA
    c548d3f View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Merge branch 'master' into read_write_locks

    @JoanFM
    JoanFM authored Feb 20, 2020
    Configuration menu
    Copy the full SHA
    a65de0b View commit details
    Browse the repository at this point in the history

  2. Remove unwanted changes

    joanfontanals committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    90b2d1c View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Merge branch 'master' into read_write_locks

    @JoanFM
    JoanFM authored Apr 14, 2020
    Configuration menu
    Copy the full SHA
    a459e67 View commit details
    Browse the repository at this point in the history

  2. Move option

    joanfontanals committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    66a6c8c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2020

  1. Merge branch 'master' into read_write_locks

    @JoanFM
    JoanFM authored Jul 11, 2020
    Configuration menu
    Copy the full SHA
    7f476f7 View commit details
    Browse the repository at this point in the history

  2. Fix problems introduced by conflict fix

    @JoanFM
    JoanFM committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    f812c31 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2020

  1. Avoid switching to c++17 and use yamc mutex library to access shared … 

    …lock functionality
    @JoanFM
    JoanFM committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    e6189ac View commit details
    Browse the repository at this point in the history

  2. Add extra yamc include

    @JoanFM
    JoanFM committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    e400481 View commit details
    Browse the repository at this point in the history

  3. Change header order

    @JoanFM
    JoanFM committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    891f5c4 View commit details
    Browse the repository at this point in the history

  4. some lint fix

    @guolinke
    guolinke committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    adbcc2d View commit details
    Browse the repository at this point in the history

  5. change include order and remove some extra blank lines

    @JoanFM
    JoanFM committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    a406a45 View commit details
    Browse the repository at this point in the history

  6. Further fix lint issues

    @JoanFM
    JoanFM committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    231c4cd View commit details
    Browse the repository at this point in the history

  7. Update c_api.cpp

    @JoanFM
    JoanFM authored Jul 12, 2020
    Configuration menu
    Copy the full SHA
    22d99f3 View commit details
    Browse the repository at this point in the history

  8. Further fix lint issues

    @JoanFM
    JoanFM committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    c01814b View commit details
    Browse the repository at this point in the history

  9. Move yamc include files to a new yamc folder

    @JoanFM
    JoanFM committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    4acbe97 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Use standard unique_lock

    @JoanFM
    JoanFM committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    46a9f70 View commit details
    Browse the repository at this point in the history

  2. Update windows/LightGBM.vcxproj 

    Co-authored-by: Guolin Ke <[email protected]>
    @JoanFM @guolinke
    JoanFM and guolinke authored Jul 13, 2020
    Configuration menu
    Copy the full SHA
    f6fc735 View commit details
    Browse the repository at this point in the history

  3. Update windows/LightGBM.vcxproj.filters 

    Co-authored-by: Guolin Ke <[email protected]>
    @JoanFM @guolinke
    JoanFM and guolinke authored Jul 13, 2020
    Configuration menu
    Copy the full SHA
    22f45a8 View commit details
    Browse the repository at this point in the history

  4. Update windows/LightGBM.vcxproj.filters 

    Co-authored-by: Nikita Titov <[email protected]>
    @JoanFM @StrikerRUS
    JoanFM and StrikerRUS authored Jul 13, 2020
    Configuration menu
    Copy the full SHA
    d255725 View commit details
    Browse the repository at this point in the history

  5. Update windows/LightGBM.vcxproj.filters 

    Co-authored-by: Nikita Titov <[email protected]>
    @JoanFM @StrikerRUS
    JoanFM and StrikerRUS authored Jul 13, 2020
    Configuration menu
    Copy the full SHA
    e650130 View commit details
    Browse the repository at this point in the history

  6. Update windows/LightGBM.vcxproj.filters 

    Co-authored-by: Nikita Titov <[email protected]>
    @JoanFM @StrikerRUS
    JoanFM and StrikerRUS authored Jul 13, 2020
    Configuration menu
    Copy the full SHA
    22945c6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of https://github.com/microsoft/LightGBM into r… 

    …ead_write_locks
    @JoanFM
    JoanFM committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    78d2fc6 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Merge branch 'master' into read_write_locks

    @JoanFM
    JoanFM committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    611e3ea View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/microsoft/LightGBM into r… 

    …ead_write_locks
    @JoanFM
    JoanFM committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e20f230 View commit details
    Browse the repository at this point in the history

  3. Fix problems coming from merge conflict resolution

    @JoanFM
    JoanFM committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    61c59fe View commit details
    Browse the repository at this point in the history