Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [R-package] update to new R-hub container images #6116

Closed
jameslamb opened this issue Sep 29, 2023 · 1 comment · Fixed by #6523
Closed

[ci] [R-package] update to new R-hub container images #6116

jameslamb opened this issue Sep 29, 2023 · 1 comment · Fixed by #6523

Comments

@jameslamb
Copy link
Collaborator

Summary

This project should switch linux R-package CI jobs away from these R-hub images: https://github.com/r-hub/rhub-linux-builders

and use these instead: https://github.com/r-hub/containers

Motivation

It seems to me based on r-hub/rhub-linux-builders#67 (comment) that r-hub/rhub-linux-builders is effectively abandoned, and that efforts from R-hub are going into this new r-hub/containers project.

Given that, the r-hub/containers images should more closely match CRAN,, and therefore improve the changes of catching issues here in LightGBM's CI prior to submitting to CRAN.

Description

This should be modified to pull from the new images:

container: rhub/debian-clang-devel

And this workaround can (hopefully) be removed:

- name: update to clang 15
shell: bash
run: |
# remove clang stuff that comes installed in the image
apt-get autoremove -y --purge \
clang-* \
libclang-* \
libunwind-* \
llvm-*
#
# replace it all with clang-15
apt-get update -y
apt-get install --no-install-recommends -y \
gnupg \
lsb-release \
software-properties-common \
wget
#
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add -
#
add-apt-repository "deb http://apt.llvm.org/unstable/ llvm-toolchain main"
apt-get install -y --no-install-recommends \
clang-15 \
clangd-15 \
clang-format-15 \
clang-tidy-15 \
clang-tools-15 \
lldb-15 \
lld-15 \
llvm-15-dev \
llvm-15-tools \
libomp-15-dev \
libc++-15-dev \
libc++abi-15-dev \
libclang-common-15-dev \
libclang-15-dev \
libclang-cpp15-dev \
libunwind-15-dev
# overwrite everything in /usr/bin with the new v15 versions
cp --remove-destination /usr/lib/llvm-15/bin/* /usr/bin/

References

In #5661 / #5662, this project took on a workaround to update to clang-15 in the one CI job here that tries to replicate the r-devel-linux-x86_64-debian-clang CRAN check flavor, to match what CRAN was using.

That was done because the r-hub container images weren't being updated, as the maintainers of those containers said they'd soon be switching to something new: r-hub/rhub-linux-builders#63 (comment).

@jameslamb jameslamb self-assigned this Sep 29, 2023
@jameslamb
Copy link
Collaborator Author

I've assigned this to myself as I'm actively working on it. I think it might also help with #5987 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment