[swig] switch to SWIG_ADD_LIBRARY() in CMakeLists.txt

[jameslamb]

Summary

Starting with cmake 3.8, compilation of SWIG targets for LightGBM raises the following deprecation warning.

CMake Deprecation Warning at /usr/local/share/cmake-3.23/Modules/UseSWIG.cmake:734 (message):
  SWIG_ADD_MODULE is deprecated.  Use SWIG_ADD_LIBRARY instead.
Call Stack (most recent call first):
  CMakeLists.txt:460 (swig_add_module)

The project should be modified to avoid that warning.

Motivation

Removes a warning in compilation logs, reducing the risk of other important information being missed.

Reduces the risk of LightGBM SWIG compilation failing on future releases of CMake where SWIG_ADD_MODULE() is removed.

Description

1. Replace uses of SWIG_ADD_MODULE() in CMakeLists.txt with SWIG_ADD_LIBRARY().

2. the minimum required version for CMake should be increased to 3.8 when compiling the SWIG targets.

LightGBM/CMakeLists.txt

Lines 28 to 36 in f1d3181

	if(__INTEGRATE_OPENCL)
	cmake_minimum_required(VERSION 3.11)
	elseif(USE_GPU OR APPLE)
	cmake_minimum_required(VERSION 3.2)
	elseif(USE_CUDA OR USE_CUDA_EXP)
	cmake_minimum_required(VERSION 3.16)
	else()
	cmake_minimum_required(VERSION 3.0)
	endif()

References

SWIG_ADD_LIBRARY() has been available since CMake 3.8 (docs link), which was released in November 2018 (release details).

[shogohida]

Hi @jameslamb, I made a pull request which fixes this issue. Please take a look!

#5603

[github-actions]

This issue has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.