Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply isort to python_package and corresponding tests #3958

Closed
30 tasks done
zyxue opened this issue Feb 14, 2021 · 2 comments · Fixed by #3990
Closed
30 tasks done

Apply isort to python_package and corresponding tests #3958

zyxue opened this issue Feb 14, 2021 · 2 comments · Fixed by #3990

Comments

@zyxue
Copy link
Contributor

zyxue commented Feb 14, 2021

Summary

Apply isort to all python files, including tests

Motivation

Consistent imports order improves readability

Description

Per discussion at #3957 (comment), isort will be applied to the following files, which are selected with

fd --exclude external_libs -F '.py' | sort

one PR at a time for ease of review:

  • docs/conf.py
  • examples/python-guide/advanced_example.py
  • examples/python-guide/logistic_regression.py
  • examples/python-guide/plot_example.py
  • examples/python-guide/simple_example.py
  • examples/python-guide/sklearn_example.py
  • helpers/check_dynamic_dependencies.py
  • helpers/parameter_generator.py
  • python-package/lightgbm/__init__.py
  • python-package/lightgbm/basic.py
  • python-package/lightgbm/callback.py
  • python-package/lightgbm/compat.py
  • python-package/lightgbm/dask.py
  • python-package/lightgbm/engine.py
  • python-package/lightgbm/libpath.py
  • python-package/lightgbm/plotting.py
  • python-package/lightgbm/sklearn.py
  • python-package/setup.py
  • tests/c_api_test/test_.py
  • tests/cpp_test/test.py
  • tests/python_package_test/__init__.py
  • tests/python_package_test/test_basic.py
  • tests/python_package_test/test_consistency.py
  • tests/python_package_test/test_dask.py
  • tests/python_package_test/test_dual.py
  • tests/python_package_test/test_engine.py
  • tests/python_package_test/test_plotting.py
  • tests/python_package_test/test_sklearn.py
  • tests/python_package_test/test_utilities.py
  • tests/python_package_test/utils.py

References

zyxue added a commit to zyxue/LightGBM that referenced this issue Feb 14, 2021
zyxue added a commit to zyxue/LightGBM that referenced this issue Feb 14, 2021
zyxue added a commit to zyxue/LightGBM that referenced this issue Feb 14, 2021
zyxue added a commit to zyxue/LightGBM that referenced this issue Feb 14, 2021
zyxue added a commit to zyxue/LightGBM that referenced this issue Feb 14, 2021
@StrikerRUS
Copy link
Collaborator

@zyxue Thank you very much for your great contribution and original feature request!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants