Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] remove testing dependency on dask-ml #3796

Closed
jameslamb opened this issue Jan 20, 2021 · 3 comments · Fixed by #3849
Closed

[dask] remove testing dependency on dask-ml #3796

jameslamb opened this issue Jan 20, 2021 · 3 comments · Fixed by #3849
Labels
dask good first issue

Comments

@jameslamb
Copy link
Collaborator

jameslamb commented Jan 20, 2021 •
edited
Loading

Summary

See #3708 (comment). LightGBM's tests currently rely on installing dask-ml, but only for a few lightweight metrics functions.

dask-ml should be factored out of the tests and CI scripts.

Motivation

This would reduce the risk of dependency conflicts in CI setup and speed up builds a bit.

References

@ffineis originally did this in #3708 (comment), but I asked him to pull it out into a separate future PR.
@jameslamb jameslamb mentioned this issue Jan 20, 2021
Open
@jameslamb
Copy link
Collaborator Author

@ffineis I'm gonna take this one today

@ffineis
Copy link
Contributor

ffineis commented Jan 22, 2021 via email

jameslamb added a commit to jameslamb/LightGBM that referenced this issue Jan 25, 2021
@jameslamb
[dask] factor dask-ml out of tests (fixes microsoft#3796)
a1dd3d8
@jameslamb jameslamb mentioned this issue Jan 25, 2021
Merged
StrikerRUS added a commit that referenced this issue Jan 25, 2021
@jameslamb @StrikerRUS
[dask] factor dask-ml out of tests (fixes #3796) (#3849)
0297719 
* [dask] factor dask-ml out of tests (fixes #3796)

* Update tests/python_package_test/test_dask.py

Co-authored-by: Nikita Titov <[email protected]>

Co-authored-by: Nikita Titov <[email protected]>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dask good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dask] factor dask-ml out of tests (fixes #3796) jameslamb/LightGBM
2 participants
@jameslamb @ffineis