Skip to content

Commit

Permalink
[C++] Remove template parameters from constructors (#6514)
Browse files Browse the repository at this point in the history
  • Loading branch information
hgminh95 authored Jul 5, 2024
1 parent 3e6156a commit a5054f7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/io/dense_bin.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ class DenseBin : public Bin {
#endif
std::vector<uint8_t> buf_;

DenseBin<VAL_T, IS_4BIT>(const DenseBin<VAL_T, IS_4BIT>& other)
DenseBin(const DenseBin<VAL_T, IS_4BIT>& other)
: num_data_(other.num_data_), data_(other.data_) {}
};

Expand Down
2 changes: 1 addition & 1 deletion src/io/multi_val_dense_bin.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ class MultiValDenseBin : public MultiValBin {
std::vector<uint32_t> offsets_;
std::vector<VAL_T, Common::AlignmentAllocator<VAL_T, 32>> data_;

MultiValDenseBin<VAL_T>(const MultiValDenseBin<VAL_T>& other)
MultiValDenseBin(const MultiValDenseBin<VAL_T>& other)
: num_data_(other.num_data_), num_bin_(other.num_bin_), num_feature_(other.num_feature_),
offsets_(other.offsets_), data_(other.data_) {
}
Expand Down
3 changes: 1 addition & 2 deletions src/io/multi_val_sparse_bin.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,7 @@ class MultiValSparseBin : public MultiValBin {
std::vector<INDEX_T> t_size_;
std::vector<uint32_t> offsets_;

MultiValSparseBin<INDEX_T, VAL_T>(
const MultiValSparseBin<INDEX_T, VAL_T>& other)
MultiValSparseBin(const MultiValSparseBin<INDEX_T, VAL_T>& other)
: num_data_(other.num_data_),
num_bin_(other.num_bin_),
estimate_element_per_row_(other.estimate_element_per_row_),
Expand Down
2 changes: 1 addition & 1 deletion src/io/sparse_bin.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ class SparseBin : public Bin {

SparseBin<VAL_T>* Clone() override;

SparseBin<VAL_T>(const SparseBin<VAL_T>& other)
SparseBin(const SparseBin<VAL_T>& other)
: num_data_(other.num_data_),
deltas_(other.deltas_),
vals_(other.vals_),
Expand Down

0 comments on commit a5054f7

Please sign in to comment.