Merge remote-tracking branch 'origin/master' into docs

microsoft · Jun 4, 2019 · 5443dab · 5443dab
2 parents 05404c0 + b6f6578
commit 5443dab
Show file tree

Hide file tree

Showing 19 changed files with 1,354 additions and 1,008 deletions.
diff --git a/R-package/R/callback.R b/R-package/R/callback.R
diff --git a/R-package/R/lgb.Booster.R b/R-package/R/lgb.Booster.R
@@ -5,7 +5,7 @@ Booster <- R6::R6Class(
   public = list(
 
     best_iter = -1,
-    best_score = -1,
+    best_score = NA,
     record_evals = list(),
 
     # Finalize will free up the handles
@@ -517,7 +517,7 @@ Booster <- R6::R6Class(
           # Parse and store privately names
           names <- strsplit(names, "\t")[[1]]
           private$eval_names <- names
-          private$higher_better_inner_eval <- grepl("^ndcg|^auc$", names)
+          private$higher_better_inner_eval <- grepl("^ndcg|^map|^auc$", names)
 
         }