-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support STL implementations without ios #933
Comments
We don't officially support EASTL. However, if you would like to create a PR which adds support for EASTL, I will gladly review it. |
I'd be glad to, however EASTL is not a drop-in STL implementation. It does not declare anything in the std namespace; I use custom forward headers to achieve this. So it wouldn't really be possible for GSL to "support" EASTL in that kind of way. What I'm proposing is a define to disable the usage of |
I'll propose another PR to solve this issue that removes the ostream operator entirely. I'll reach out to some of the Core Guidelines editors to get their opinions on which approach is more appropriate. Edit: correction to previous statement. I forgot that C++20 has a non-member function for both unique_ptr and shared_ptr operator<< |
@gdr-at-ms or @hsutter Would you mind taking a look at both #935 and #940 and letting us know which version works better with regards to the Core Guidelines? |
Thanks! |
I'm working with EASTL as STL implementation, which does not implement ios.
<gsl/pointers>
includesiosfwd
to be able to defineoperator<<
fornot_null
, so I presently cannot use these features. It would be useful to be able to disable the generation of this operator so that the GSL can work without iostreams.The text was updated successfully, but these errors were encountered: