Add accessibility info to summary diagrams #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
reviewed
Oct 6, 2020
| {{< /mermaid >}} | ||
|
|
||
| <span class="screen-reader-text"> | ||
| <ul aria-label="Describes the hierarchical structure of the summary tree from the root to the first layer of leaf nodes."> |
There was a problem hiding this comment.
These aren't being read off by narrator. It goes from the above paragraph into the list itself
The root node corresponds to the Container, and it contains the protocol information as well as any partially processed chunk op data.
Enter List, 1 of 1 level 1, bullet, root
1 of 5 level 2, hollow bullet, .protocol
2 of 5 level 2, hollow bullet, _scheduler
There was a problem hiding this comment.
Since we're already hiding this section, this aria-label would probably do better as a paragraph tag on it's own.
There was a problem hiding this comment.
a label and labeledby works really well
There was a problem hiding this comment.
Nice! Thanks for the suggestion. Will address in the next iteration.
micahgodbolt
suggested changes
Oct 6, 2020
micahgodbolt
reviewed
Oct 7, 2020
micahgodbolt
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3621.