Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(devtools-view): Move axe-core to devDependencies #22797

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

alexvy86
Copy link
Contributor

Description

axe-core is used for accessibility tests only, it doesn't need to be a prod dep.

Reviewer Guidance

The review process is outlined on this wiki page.

@alexvy86 alexvy86 requested review from WayneFerrao and a team October 14, 2024 21:18
@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Oct 14, 2024
@alexvy86 alexvy86 enabled auto-merge (squash) October 14, 2024 21:18
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.57 KB 459.61 KB +35 Bytes
azureClient.js 556.79 KB 556.84 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.19 KB 259.2 KB +14 Bytes
fluidFramework.js 405.81 KB 405.82 KB +14 Bytes
loader.js 134.24 KB 134.25 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.29 KB 148.29 KB +7 Bytes
odspClient.js 523.75 KB 523.8 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.48 KB 164.49 KB +7 Bytes
sharedTree.js 396.27 KB 396.28 KB +7 Bytes
Total Size 3.31 MB 3.31 MB +245 Bytes

Baseline commit: aec0233

Generated by 🚫 dangerJS against 46b2355

@alexvy86 alexvy86 merged commit c74e1ce into microsoft:main Oct 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants