-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tree): Include list of properties that changed in nodeChanged event #22229
Conversation
…to node-changed-details
…se in simple tree test utils.
A usability issue with this APi has been reported: Lack of strong typing of the keys least to string names for keys in code easily getting out of date (or having typos) with no compile errors. There are two ways this could be improved:
|
## Description Refactor TreeNodeKernel. Makes its events in terms of the internal anchor node events instead of the public API surface, allowing for the public API surface to be tweaked in node kind specific ways. Track the disposed state more clearly. Move generation number logic from array nodes to node kernel where other kinds could use it (ex: to error when iterating map keys if the map was modified) and implementation is simpler. Changes split out from #22229 for separate review.
## Description Improve TreeChangeEvents docs. Split out from #22229
## Description Clarify docs and comments to refer to property keys not view keys. Changes split out from #22229 for separate review.
## Description Split off from #22229 for a smaller review.
Fixed. Also moved API to beta incase there are more such issues. |
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Description
Updated version of #22043 .
See changeset for details.
Reviewer Guidance
The review process is outlined on this wiki page.