refactor: Add hostRequirements section to devcontainer.json #19473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WayneFerrao
approved these changes
Feb 5, 2024
kian-thompson
pushed a commit
to kian-thompson/FluidFramework
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
hostRequirementssection to our devcontainer.json file, just so Codespaces defaults to those settings when creating a new instance. Per the docs, this won't block different configurations from working, cloud services might just present warnings if spinning up the container with fewer resources.Reviewer Guidance
The review process is outlined on this wiki page.
Curious if anyone has concerns about this. I know some people don't create many new codespaces, they just use git worktrees inside a single one. Not sure how many of us frequently-ish spin up brand new codespaces and how annoyed we are to have to change the default settings when doing it from the Github UI :)