Enable writing isolated channels by default (#6231)

* Enable isolated channels * Point to PR for snapshot tests * Point to correct PR commit * Update to latest * Revert to PR commit * Move to latest PR commit * Fix gc summary tests * Fix more tests
microsoft · May 27, 2021 · ecbf0d8 · ecbf0d8
1 parent 8160549
commit ecbf0d8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/packages/runtime/container-runtime/src/containerRuntime.ts b/packages/runtime/container-runtime/src/containerRuntime.ts
@@ -811,8 +811,8 @@ export class ContainerRuntime extends TypedEventEmitter<IContainerRuntimeEvents>
             && !this.runtimeOptions.gcOptions.disableGC
         );
 
-        // Default to true (disabled) until a few versions have passed.
-        this.disableIsolatedChannels = this.runtimeOptions.summaryOptions.disableIsolatedChannels ?? true;
+        // Default to false (enabled).
+        this.disableIsolatedChannels = this.runtimeOptions.summaryOptions.disableIsolatedChannels ?? false;
 
         this._connected = this.context.connected;
         this.chunkMap = new Map<string, string[]>(chunks);

diff --git a/packages/test/snapshots/content b/packages/test/snapshots/content
diff --git a/packages/test/test-end-to-end-tests/src/test/gcReferenceUpdatesInLocalSummary.spec.ts b/packages/test/test-end-to-end-tests/src/test/gcReferenceUpdatesInLocalSummary.spec.ts
@@ -106,7 +106,8 @@ describeNoCompat("GC reference updates in local summary", (getTestObjectProvider
         });
 
         let dataStoreTree: ISummaryTree | undefined;
-        for (const [ id, summaryObject ] of Object.entries(summary.tree)) {
+        const channelsTree = (summary.tree[".channels"] as ISummaryTree)?.tree ?? summary.tree;
+        for (const [ id, summaryObject ] of Object.entries(channelsTree)) {
             if (id === dataStoreId) {
                 assert(
                     summaryObject.type === SummaryType.Tree,

diff --git a/packages/test/test-end-to-end-tests/src/test/gcSummaryTests.spec.ts b/packages/test/test-end-to-end-tests/src/test/gcSummaryTests.spec.ts
@@ -84,7 +84,9 @@ describeNoCompat("Garbage Collection", (getTestObjectProvider) => {
          */
         function validateDataStoreInSummary(summary: ISummaryTree, dataStoreId: string, referenced: boolean) {
             let dataStoreTree: ISummaryTree | undefined;
-            for (const [ id, summaryObject ] of Object.entries(summary.tree)) {
+            // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+            const channelsTree = (summary.tree[".channels"] as ISummaryTree)?.tree ?? summary.tree;
+            for (const [ id, summaryObject ] of Object.entries(channelsTree)) {
                 if (id === dataStoreId) {
                     assert(
                         summaryObject.type === SummaryType.Tree,