-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using init-only setter for netstandard #450
Conversation
Is it possible we can add test to make sure we are netstandard/netfx 4.x compatible? |
Currently, the I checked other .net libraries which targets on netstandard, I found they didn't specify the Maybe, we should do the same thing. |
Maybe we should set the However, async stream is not available in C# 7.3 (need 8.0+), so the |
The |
Using language version 8.0.0 would ensure we couldn't write init only setters. It also prevents us from taking advantage of new language features but that may be what makes sense since we are supporting netstandard. |
…-Dotnet into zhiyuanliang/not-use-init
@@ -15,7 +15,8 @@ | |||
<SignAssembly>true</SignAssembly> | |||
<DelaySign>false</DelaySign> | |||
<AssemblyOriginatorKeyFile>..\..\build\Microsoft.FeatureManagement.snk</AssemblyOriginatorKeyFile> | |||
<LangVersion>9.0</LangVersion> | |||
<!-- Microsoft.FeatureManagement uses the feature of async streams which is not supported in versions of C# earlier than 8.0. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention why we don't use later than version 8.0
…oft/FeatureManagement-Dotnet into zhiyuanliang/not-use-init
/AzurePipeline run |
/AzurePipeline run |
Azure Pipelines successfully started running 1 pipeline(s). |
Why this PR?
#435
Visible change
Replace
init
setter toset