Moves cache busting and handles null #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
A developer had an issue. After refresh they were getting:
After trying to recreate the issue, I found one way. The steps are as follows:
FeatureManager.GetFeatureNamesAsync()
.ConfigurationFeatureDefinitionProvider.GetAllFeatureDefinitionsAsync
will iterate once, meaning it will grab a list of allIConfigurationSections
defined within FeatureManagement, but only iterate the first one )IsEnabledAsync("RemovedFlag")
or iterate through a fullGetFeatureNamesAsync
. This fills the cache with "null".In short- the cache gets busted when the refresh happens, but the old AsyncEnumerable is not updated. It expects the IConfigurationSection it saw before iterating to still exist.
Visible Changes
This fix is in two places-
AsyncEnumerable
inConfigurationFeatureDefinitionProvider
will check for null iteration- since iterations can be as slow as the developer wants. If the same situation happens- there might be a null in the cache, but we won't return it.