Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow different type of filters to share the same Alias #262

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Allow different type of filters to share the same Alias #262

merged 10 commits into from
Oct 26, 2023

Commits on Oct 19, 2023

  1. allow dup alias & target on main branch

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    15d6a07 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. fix bug: non-contextual filter will not be found when there is context

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    eb412f4 View commit details
    Browse the repository at this point in the history

  2. keep using ContextualFeatureFilterEvaluator.IsContextualFilter

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    745ea3e View commit details
    Browse the repository at this point in the history

  3. fix bug

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b5a10f6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into zhiyuanliang/allow-dup-alias

    @zhiyuanliang-ms
    zhiyuanliang-ms authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8483c5e View commit details
    Browse the repository at this point in the history

  5. use typeof & avoid using repeated code

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c4192a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. resolve comments & add testcase

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    6082e9f View commit details
    Browse the repository at this point in the history

  2. resolve comments

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b0bd5df View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. remove unnecessary '?'

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f57bd7f View commit details
    Browse the repository at this point in the history

  2. use var

    @zhiyuanliang-ms
    zhiyuanliang-ms committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d39de05 View commit details
    Browse the repository at this point in the history