avoid null reference (#457)

microsoft · Jun 1, 2024 · d90fa76 · d90fa76
1 parent d9ff1af
commit d90fa76
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Microsoft.FeatureManagement/Targeting/TargetingEvaluator.cs b/src/Microsoft.FeatureManagement/Targeting/TargetingEvaluator.cs
@@ -190,7 +190,7 @@ public static bool IsTargeted(
             if (sourceGroups != null)
             {
                 IEnumerable<string> normalizedGroups = ignoreCase ?
-                    sourceGroups.Select(g => g.ToLower()) :
+                    sourceGroups.Select(g => g?.ToLower()) :
                     sourceGroups;
 
                 foreach (string group in normalizedGroups)
@@ -232,13 +232,13 @@ public static bool IsTargeted(
             }
 
             string userId = ignoreCase ?
-                targetingContext.UserId.ToLower() :
+                targetingContext.UserId?.ToLower() :
                 targetingContext.UserId;
 
             if (targetingContext.Groups != null)
             {
                 IEnumerable<string> normalizedGroups = ignoreCase ?
-                    targetingContext.Groups.Select(g => g.ToLower()) :
+                    targetingContext.Groups.Select(g => g?.ToLower()) :
                     targetingContext.Groups;
 
                 foreach (string group in normalizedGroups)
@@ -280,7 +280,7 @@ public static bool IsTargeted(
             }
 
             string userId = ignoreCase ?
-                targetingContext.UserId.ToLower() :
+                targetingContext.UserId?.ToLower() :
                 targetingContext.UserId;
 
             string defaultContextId = $"{userId}\n{hint}";
@@ -319,7 +319,7 @@ public static bool IsTargeted(ITargetingContext targetingContext, double from, d
             }
 
             string userId = ignoreCase ?
-                targetingContext.UserId.ToLower() :
+                targetingContext.UserId?.ToLower() :
                 targetingContext.UserId;
 
             string contextId = $"{userId}\n{hint}";