Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenGrab DDS needs support for planar formats #271

Open
walbourn opened this issue Oct 16, 2024 · 1 comment
Open

ScreenGrab DDS needs support for planar formats #271

walbourn opened this issue Oct 16, 2024 · 1 comment
Labels

Comments

@walbourn
Copy link
Member

Currently ScreenGrab only works on formats with a plane count of 1. This means you can't currently capture the following:

DXGI_FORMAT_NV12:      // 4:2:0 8-bit
DXGI_FORMAT_P010:      // 4:2:0 10-bit
DXGI_FORMAT_P016:      // 4:2:0 16-bit
DXGI_FORMAT_420_OPAQUE:// 4:2:0 8-bit
DXGI_FORMAT_NV11:      // 4:1:1 8-bit
@walbourn walbourn added the bug label Oct 16, 2024
@walbourn
Copy link
Member Author

walbourn commented Oct 16, 2024

Also, on DX12 the depth formats are treated as planar, but in DX11 the DDS files were interleaved.

microsoft/DirectXTex#46

This lack of support for planar formats means all depth formats with stencil also fail:

case DXGI_FORMAT_R32G8X24_TYPELESS:
case DXGI_FORMAT_D32_FLOAT_S8X24_UINT:
case DXGI_FORMAT_R32_FLOAT_X8X24_TYPELESS:
case DXGI_FORMAT_X32_TYPELESS_G8X24_UINT:
case DXGI_FORMAT_R24G8_TYPELESS:
case DXGI_FORMAT_D24_UNORM_S8_UINT:
case DXGI_FORMAT_R24_UNORM_X8_TYPELESS:
case DXGI_FORMAT_X24_TYPELESS_G8_UINT:
case XBOX_DXGI_FORMAT_D16_UNORM_S8_UINT:
case XBOX_DXGI_FORMAT_R16_UNORM_X8_TYPELESS:
case XBOX_DXGI_FORMAT_X16_TYPELESS_G8_UINT:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant