Remove ExtractRecordStructFromArray intrinsic #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob80905
force-pushed
the
elim_hidden_intrinsicsv2
branch
from
5f93c33 to
ce5cd72
Compare
python3kgae
approved these changes
Nov 30, 2023
tex3d
reviewed
Nov 30, 2023
tools/clang/test/HLSLFileCheck/hlsl/workgraph/ast-nodeoutput.hlsl
Outdated
Show resolved
Hide resolved
tex3d
reviewed
Nov 30, 2023
tools/clang/test/HLSLFileCheck/passes/hl/sroa_hlsl/NodeInput_type.ll
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ExtractRecordStructFromArray intrinsic is left over dead code that should be removed. This PR removes the intrinsic from existence. In the cases where this intrinsic was used, DefaultSubscript is used instead.
Moved from #5893 to target the main branch instead.
Fixes #5351