Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize projects #662

Closed
wants to merge 13 commits into from
Closed

Sanitize projects #662

wants to merge 13 commits into from

Conversation

longod
Copy link

@longod longod commented Oct 16, 2020

I fixed all projects building.

  • Fix .gitignore based on Github template
  • Upgrade solutions to VS2019 or VS2017 (some legacy projects)
  • Use v142 toolset on VS2019 sln and use v141 toolset on VS2017 sln
  • Fix Windows SDK version
  • Fix PIX version
  • Fix Package path on ModelConverter
  • Fix linking on Desktop/D3D12LinkedGpus and UWP/D3D12Residency
  • Add a missing model for D3D12RaytracingMiniEngineSample
  • Fix deprecated function on D3D12MemoryManagement

@ghost
Copy link

ghost commented Oct 16, 2020

CLA assistant check
All CLA requirements met.

@walbourn walbourn added the samples Issues related to Samples label Feb 4, 2022
@walbourn
Copy link
Member

walbourn commented Feb 4, 2022

This is a lot of change in this PR, but I see at least a few source changes that we should take. Can you submit the .cpp/.h file changes in their own PR?

@longod
Copy link
Author

longod commented Feb 5, 2022

Over the past year, it seems that most of these problems have been fixed by other PRs.
Thanks #730.

@longod longod closed this Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues related to Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants