Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance counters fix for version 2022 and overall formatting (XTP rebuilded) #213

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

tiagodiasfernandes
Copy link
Contributor

Fixes # .
Performance counters fix for version 2022 and overall formatting (XTP rebuilded)

Changes proposed in this pull request:
Performance counters fix for version 2022 and overall formatting (XTP rebuilded)

How to test this code:
Execute pssdiag and open counters file

Has been tested on (remove any that don't apply):

  • Case-sensitive SQL Server instance
  • SQL Server 2016
  • SQL Server 2017
  • SQL Server 2019
  • SQL Server 2022
  • Azure SQL Virtual Machine

Some counters didn't had SQL 2022 version option yet.
…w from scratch

SQL Versions 2017 and 2019 have the same counters named 2017
SQL 2016 don't have 3 counters present on the other versions
Copy link
Contributor

@PiJoCoder PiJoCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - looks good. Thank you for your contribution

@PiJoCoder PiJoCoder merged commit 383ab33 into microsoft:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants