Multicopypowershellmove #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new powershell command to replaced the cmd command
I rewrote the multicopy.cmd into a powershell script. Please test.
1. Moved the Multicopy.ps1 to pristine folder. 2. Fixed Named Instance bug and parsed out he instance name for the file name. 3. Updated Custom Diag for SQLDIAG
PiJoCoder
reviewed
Nov 1, 2022
1. Fixed Named instance parsing 2. Added Multi copy to AG base group 3. Added Multi copy to Polybase group
…o multicopypowershellmove
PiJoCoder
reviewed
Nov 2, 2022
PiJoCoder
reviewed
Nov 2, 2022
| @@ -0,0 +1,22 @@ | |||
| param( | |||
There was a problem hiding this comment.
You really don't need this file. You should remove it from project. The one in Pristine folder covers all Custom Collectors
PiJoCoder
requested changes
Nov 2, 2022
…o multicopypowershellmove
1.Removed comments from Custom Diag 2. updated error message write out.
Removed comments.
…t/DiagManager into multicopypowershellmove
Co-Authored-By: Kenny <[email protected]>
PiJoCoder
approved these changes
Nov 2, 2022
Co-Authored-By: Kenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
How to test this code:
Has been tested on (remove any that don't apply):