Tiagofe Perfmon counter translation #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translate Performance Counters from english to server local language. Not ready to prod, 1st version.
This performance counter is missing a backslash
created translate process with hashtables - 1 minute execution improvement - takes 11 seconds now created confirmation of translation to duplicated performance counters names
Added if statement if language is not English. Optimized performance changing select-object logic. Full execution now takes 5 seconds
Improved some performance . added the new ps1 process and removed diagutil.exe call added file to project
small bug, the "-"
write-host on the end statement
Old cmdlet was not getting correct statements
PiJoCoder
changed the title
|
Completed testing on a Spanish-language OS. Looks good. Will be merging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
It was created a new PowerShell method to translate the performance counter xml to local language if not in english.
How to test this code:
Execute pssdiag on a non English OS and SQL.
Has been tested on (remove any that don't apply):