PNPM workspaces

.vscode/launch.json

@@ -5,11 +5,48 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "type": "pwa-chrome",
+      "name": "dtslint-runner local all",
+      "program": "${workspaceFolder}/packages/dtslint-runner/dist/index.js",
       "request": "launch",
-      "name": "Launch Chrome against localhost",
-      "url": "http://localhost:8080",
-      "webRoot": "${workspaceFolder}"
-    }
+      "skipFiles": [
+        "<node_internals>/**"
+      ],
+      "args": [
+          "--path", "../DefinitelyTyped", "--selection", "all", "--localTypeScriptPath", "../../ts/built/local",
+      ],
+
+      "type": "node"
+    },
+    {
+      "name": "jest",
+      "program": "${workspaceFolder}/node_modules/.bin/jest",
+      "request": "launch",
+      "skipFiles": [
+        "<node_internals>/**"
+      ],
+      "args": [ "definitions-parser"],
+      "type": "node"
+    },
+    {
+      "name": "dts-critic test",
+      "program": "${workspaceFolder}/packages/dts-critic/dist/index.js",
+      "request": "launch",
+      "skipFiles": [
+        "<node_internals>/**"
+      ],
+      "args": [ "--dts", "packages/dts-critic/testsource/tslib/index.d.ts", ],
+      "type": "node"
+    },
+    {
+      "name": "dtslint aframe",
+      "program": "${workspaceFolder}/packages/dtslint/dist/index.js",
+      "request": "launch",
+      "skipFiles": [
+        "<node_internals>/**"
+      ],
+      "args": [ "../DefinitelyTyped/types/aframe", ],
+
+      "type": "node"
+    },
   ]
 }

package.json

@@ -20,14 +20,14 @@
     "@typescript-eslint/eslint-plugin": "^5.55.0",
     "@typescript-eslint/parser": "^5.55.0",
     "eslint": "^7.31.0",
-    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-jsdoc": "^30.7.8",
     "jest": "^29.5.0",
     "lerna": "^4.0.0",
     "prettier": "^2.6.2",
     "ts-jest": "^29.0.5",
     "tslint": "^6.1.2",
     "tslint-microsoft-contrib": "^6.2.0",
-    "typescript": "^5.0.2"
+    "typescript": "next"
   }
 }

packages/definitions-parser/src/get-affected-packages.ts

@@ -6,7 +6,9 @@ import {
   PackageBase,
   getMangledNameForScopedPackage,
   formatDependencyVersion,
+  removeTypesScope,
 } from "./packages";
+import { tryParsePackageVersion } from './lib/definition-parser';
 
 export interface Affected {
   readonly changedPackages: readonly TypingsData[];
@@ -25,11 +27,6 @@ export function getAffectedPackages(allPackages: AllPackages, changedPackageIds:
   return { changedPackages: changed, dependentPackages: sortPackages(dependent), allPackages };
 }
 
-/** Every package name in the original list, plus their dependencies (incl. dependencies' dependencies). */
-export function allDependencies(allPackages: AllPackages, packages: Iterable<TypingsData>): TypingsData[] {
-  return sortPackages(transitiveClosure(packages, (pkg) => allPackages.allDependencyTypings(pkg)));
-}
-
 /** Collect all packages that depend on changed packages, and all that depend on those, etc. */
 function collectDependers(
   changedPackages: PackageId[],
@@ -87,15 +84,8 @@ function getReverseDependencies(
     }
   }
   for (const typing of allPackages.allTypings()) {
-    for (const [name, version] of Object.entries(typing.dependencies)) {
-      const dependencies = map.get(packageIdToKey(allPackages.tryResolve({ name, version })));
-      if (dependencies) {
-        dependencies[1].add(typing.id);
-      }
-    }
-    for (const dependencyName of typing.testDependencies) {
-      const version = typing.pathMappings[dependencyName] || "*";
-      const dependencies = map.get(packageIdToKey(allPackages.tryResolve({ name: dependencyName, version })));
+    for (const [ name, version ] of typing.allPackageJsonDependencies()) {
+      const dependencies = map.get(packageIdToKey(allPackages.tryResolve({ name: removeTypesScope(name), version: tryParsePackageVersion(version) })));
       if (dependencies) {
         dependencies[1].add(typing.id);
       }

packages/definitions-parser/src/git.ts

@@ -103,13 +103,12 @@ export async function getAffectedPackagesFromDiff(
 
   const affected =
     selection === "all"
-      ? { changedPackages: allPackages.allTypings(), dependentPackages: [], allPackages }
+      ? { changedPackages: allPackages.allTypings(), dependentPackages: [] }
       : selection === "affected"
       ? getAffectedPackages(allPackages, gitChanges(diffs))
       : {
           changedPackages: allPackages.allTypings().filter((t) => selection.test(t.name)),
           dependentPackages: [],
-          allPackages,
         };
 
   console.log(