Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inference Benchmark] set num_requests based on num_clients #880

Merged
merged 1 commit into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions benchmarks/inference/mii/run_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ def run_benchmark() -> None:
)
continue

if client_args.num_requests is None:
client_args.num_requests = client_args.num_clients * 4 + 32
response_details = run_client(client_args)
print_summary(client_args, response_details)
save_json_results(client_args, response_details)
Expand Down
6 changes: 2 additions & 4 deletions benchmarks/inference/mii/src/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def parse_args(
client_parser.add_argument(
"--num_requests",
type=int,
default=512,
default=None,
help="Number of requests to process by clients",
)
client_parser.add_argument(
Expand Down Expand Up @@ -159,9 +159,7 @@ def parse_args(
parser.add_argument(
"--overwrite_results", action="store_true", help="Overwrite existing results"
)
parser.add_argument(
"--fp6", action="store_true", help="Enable FP6"
)
parser.add_argument("--fp6", action="store_true", help="Enable FP6")

# Parse arguments
args = parser.parse_args()
Expand Down
Loading