Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't add eot token if add_eot_token knob is False #834

Closed
wants to merge 3 commits into from

Conversation

EeyoreLee
Copy link

  1. add a arg named add_eot_token to avoid to add eot token when args.add_eot_token is False. (fix step2 llama2)
  2. remove some redundant code. like chosen_token["input_ids"] = chosen_token["input_ids"]
  3. avoid using list as python function args default value.

@EeyoreLee EeyoreLee closed this by deleting the head repository Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants