Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPO support for DeepSpeed-Chat #828

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

stceum
Copy link
Contributor

@stceum stceum commented Dec 8, 2023

Considering the advantages of DPO(Direct Preference Optimization) as being "stable, performant, and computationally lightweight, eliminating the need for fitting a reward model, sampling from the LM during fine-tuning, or performing significant hyperparameter tuning", we add DPO support for DeepSpeed-Chat.

@stceum stceum closed this Jan 27, 2024
@stceum stceum deleted the dpo_support branch January 27, 2024 06:41
@stceum
Copy link
Contributor Author

stceum commented Jan 27, 2024

Accidentally closed the PR.. Sorry :(

@boqiny
Copy link

boqiny commented Dec 18, 2024

Hi, Thanks for sharing this. Any updates about this PR? Are we planning to merge this feature in?

@stceum
Copy link
Contributor Author

stceum commented Dec 18, 2024

Hi, Thanks for sharing this. Any updates about this PR? Are we planning to merge this feature in?

Yes, of course! The code for step2 DPO seems to be running as expected. I have done my best to make the code easy to understand and maintain the same style as the other steps. After reviewing the PR again just now, it appears to be missing a README. I will complete it ASAP.

I really appreciate your reminder :)

@tjruwase
Copy link
Contributor

@stceum, thanks for this great contribution. Apologies for the delayed review. I have approved. Please let me know when it is good to merge.

@tjruwase tjruwase removed the request for review from arashb December 28, 2024 14:48
@stceum
Copy link
Contributor Author

stceum commented Jan 2, 2025

@stceum, thanks for this great contribution. Apologies for the delayed review. I have approved. Please let me know when it is good to merge.

Hi, I've committed the README.md and the example training log. I believe it's ready on my end. Please let me know if you have any questions or find any issues with the PR. I apologize for any inconvenience during the holiday season. Happy New Year! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants