Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepspeed-chat: fix incorrect lr when using lora only #756

Merged
merged 1 commit into from
Oct 3, 2023
Merged

deepspeed-chat: fix incorrect lr when using lora only #756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions applications/DeepSpeed-Chat/training/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,12 @@ def get_optimizer_grouped_parameters(
0.0,
},
]
if not optimizer_grouped_parameters[1]["params"]:
optimizer_grouped_parameters.pop(1)
return optimizer_grouped_parameters

non_empty_groups = []
for group in optimizer_grouped_parameters:
if group["params"]:
non_empty_groups.append(group)
return non_empty_groups


def _z3_params_to_fetch(param_list):
Expand Down