deepspeed-chat: fix weight decay configuration #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosheisland
requested review from
jeffra,
samyam,
tjruwase,
ShadenSmith,
conglongli,
awan-10,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi,
duli2012,
mrwyattii,
yaozhewei,
arashb and
xiaoxiawu-microsoft
as code owners
tjruwase
requested review from
lekurile
and removed request for
arashb,
ShadenSmith,
jeffra,
duli2012,
samyam,
conglongli,
mrwyattii,
yaozhewei,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi and
xiaoxiawu-microsoft
mosheisland
force-pushed
the
6_fix_wd_config
branch
from
358c3ae to
281fc2a
Compare
lekurile
requested changes
Oct 3, 2023
lekurile
approved these changes
Oct 4, 2023
mosheisland
force-pushed
the
6_fix_wd_config
branch
from
c63d79a to
5bba361
Compare
|
@lekurile, are you ok with this PR? |
Current default name used to detect LN layers is "LayerNorm.weight". This does not work for the following models: - opt: uses "layer_norm" - llama: uses "norm" and "layernorm" - bloom: uses "layernorm" and "ln_f" Therefore, modify the default names to accomodate for the above. Also, compare names in lower-caps to capture models with different caps. Change-Id: I5b805df2663c62daf3d9c8a31a973742e344e76b Signed-off-by: Moshe Island <[email protected]>
mosheisland
force-pushed
the
6_fix_wd_config
branch
from
f327d6a to
a273e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default name used to detect LN layers is "LayerNorm.weight". This does not work for the following models:
Therefore, modify the default names to accomodate for the above. Also, compare names in lower-caps to capture models with different caps.
Change-Id: I5b805df2663c62daf3d9c8a31a973742e344e76b